Unify claim status, share fee payment helper, consolidate slug/storage docs - #426
Merged
Naomi-Gift merged 1 commit intoJul 27, 2026
Merged
Conversation
|
@king-aj-the-first Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #337
closes #340
closes #374
closes #382
Summary
Cleanup pass addressing duplicated claim/fee logic and stale docs:
ClaimStatus/ContractClaimStatusinto one sharedClaimStatus, addClaimKind, and route both ownership and contract-address approve/reject paths throughapply_claim_decision+transition_to_approved/transition_to_rejected.FeeManager::execute_fee_paymentand havepay_fee/pay_registration_feecall it with their storage keys, amounts, and event metadata.PROJECT_SLUG_IMPLEMENTATION.md+SLUG_PR_SUMMARY.mdintodocs/PROJECT_SLUG.md; delete the duplicates.STORAGE_INDEXES.mdwith liveStorageKey/ExtensionKeyusage and explicitly exclude dead scaffolding (DataKey,FeeRefundRecord,FeeConfigHistory*, unusedNextProjectId/ProjectLaunchTimestamp).Changes
Task 1 — Unified claim workflow
ContractClaimStatus;ContractClaimRequest.statusnow usesClaimStatus.ClaimKind::{Ownership, ContractAddress}.ClaimStatusandProjectRegistry::apply_claim_decision.approve_claim_request/reject_claim_requestandapprove_contract_claim/reject_contract_claimto use the shared path.ClaimStatus.Task 2 — Shared fee payment helper
execute_fee_payment(env, payer, amount, token, paid_flag_key, details_key, event_project_id, operation).pay_feekeeps owner-auth, then delegates.pay_registration_feekeeps self-auth, then delegates.Task 3 — Slug docs
docs/PROJECT_SLUG.md(merged canonical doc).PROJECT_SLUG_IMPLEMENTATION.mdandSLUG_PR_SUMMARY.md.Task 4 — Storage index docs
StorageKey::…/ExtensionKey::…).Test plan
cargo test claim(ownership claims)cargo test issues_242_252_256(contract-address claims)cargo testfee-related tests (pay_fee/ registration fee)docs/PROJECT_SLUG.mdis the only slug feature docSTORAGE_INDEXES.mddead-scaffolding list againststorage_keys.rs/types.rs