Skip to content

docs: add panic-as-DoS threat to THREAT_MODEL.md - #419

Merged
Naomi-Gift merged 3 commits into
HubDApp:mainfrom
ReinaMaze:audit/panic-dos-threat-model
Jul 27, 2026
Merged

docs: add panic-as-DoS threat to THREAT_MODEL.md#419
Naomi-Gift merged 3 commits into
HubDApp:mainfrom
ReinaMaze:audit/panic-dos-threat-model

Conversation

@ReinaMaze

Copy link
Copy Markdown
Contributor

Threat Model Update: Panic-as-DoS Risk Documentation

Add comprehensive panic-as-denial-of-service threat coverage to THREAT_MODEL.md.

Changes

  • New Section 4: Panic-as-Denial-of-Service (DoS) Risk
    • Explains threat: panic in entry points can be exploited to halt contract
    • Documents affected components with specific line numbers:
      • timelock_manager.rs (lines 49, 52, 60, 74, 77, 85, 268, 300, 325)
      • endorsement_registry.rs (line 26)
      • bookmark_registry.rs (line 28)
      • dependency_registry.rs (lines 100, 111, 122, 130)
      • review_registry.rs (lines 1074, 1075)
      • project_registry.rs (lines 1973, 1974)
      • admin_manager.rs (line 23)
    • Includes code examples for each panic site
    • Provides mitigation strategy: replace panic/unwrap with Result returns, add bounds checking, validate UTF-8
    • Lists related issues for future fixes

close #383

ReinaMaze and others added 3 commits July 24, 2026 13:44
- Add section 4: Panic-as-Denial-of-Service (DoS) Risk
- Document panic call sites in timelock_manager, endorsement_registry, bookmark_registry, dependency_registry, review_registry, project_registry, admin_manager
- Include line numbers and code examples for each vulnerability
- Provide mitigation strategy: replace panic/unwrap with Result returns, add bounds checking, validate UTF-8, handle storage errors gracefully
- List related issues for future fixes
- Renumber original unresolved risks to section 5
@Naomi-Gift
Naomi-Gift merged commit ea7a1d4 into HubDApp:main Jul 27, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit THREAT_MODEL.md against the panic/unsafe-pattern findings in this audit

2 participants