#324 FeeRefundRecord type and its storage key are unused scaffolding …#415
Open
Priest-Codes wants to merge 1 commit into
Conversation
…olding for a never-built feature FIXED
|
@Priest-Codes Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings:
The codebase contained dead/unused scaffolding for a planned but never-implemented fee-refund feature.
Two definitions were identified that were never used anywhere in the contract:
FeeRefundRecord struct in types.rs
ExtensionKey::FeeRefundRecord(u64) variant in storage_keys.rs
Fix Features Applied:
Completely removed the unused FeeRefundRecord struct definition.
Completely removed the unused FeeRefundRecord(u64) variant from the ExtensionKey enum.
Result: Clean removal of dead schema with no impact on any existing functionality.
Benefits of the Fix:
Eliminates dead code
Reduces contract size
Prevents future confusion from unused storage types
Keeps the codebase maintainable and clean
CLOSE #324