[server] don't leave modules in unknown cache state when a check raises#12992
Open
kLabz wants to merge 1 commit into
Open
[server] don't leave modules in unknown cache state when a check raises#12992kLabz wants to merge 1 commit into
kLabz wants to merge 1 commit into
Conversation
check_module sets m_cache_state to MSUnknown while checking a module and only resolves that state once the whole subgraph has been checked. If anything raises in between (e.g. a parse error while a CheckFileContentModification policy makes the check parse the file), modules stay MSUnknown with the m_checked of that compilation, which breaks the invariant asserted on the next check: File "src/compiler/server/serverCache.ml", line 258, characters 12-19 Called from ServerCache.check_module.check.check_dependencies.(fun) ... Modules cached by reference (import.hx modules, -D disable-hxb-cache) keep that state across requests, so the server keeps failing until it's restarted. Register modules in unknown_state_modules before checking them and revert their state if the check raises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_module sets m_cache_state to MSUnknown while checking a module and only resolves that state once the whole subgraph has been checked. If anything raises in between (e.g. a parse error while a CheckFileContentModification policy makes the check parse the file), modules stay MSUnknown with the m_checked of that compilation, which breaks the invariant asserted on the next check:
File "src/compiler/server/serverCache.ml", line 258, characters 12-19
Called from ServerCache.check_module.check.check_dependencies.(fun) ...
Modules cached by reference (import.hx modules, -D disable-hxb-cache) keep that state across requests, so the server keeps failing until it's restarted.
Register modules in unknown_state_modules before checking them and revert their state if the check raises.