StringTools fastCodeAt make the default case fall back to using String charCodeAt#12988
Open
PXshadow wants to merge 2 commits into
Open
StringTools fastCodeAt make the default case fall back to using String charCodeAt#12988PXshadow wants to merge 2 commits into
PXshadow wants to merge 2 commits into
Conversation
Contributor
|
Very cool! |
Contributor
|
There's likely at least one target that should still be using |
Contributor
Author
|
@kLabz Good catch, went through the compiler target list and added the 2 remaining targets to use the fast case (did not add c# because it's gone) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where a target not yet defined in the conditionals for StringTools.fastCodeAt, can still compile by using String charCodeAt.