Skip to content

ui_win: fix invocation of sentinel callback#953

Merged
yuxiaomao merged 1 commit into
HaxeFoundation:masterfrom
Apprentice-Alchemist:ui-win-sentinel
Jul 1, 2026
Merged

ui_win: fix invocation of sentinel callback#953
yuxiaomao merged 1 commit into
HaxeFoundation:masterfrom
Apprentice-Alchemist:ui-win-sentinel

Conversation

@Apprentice-Alchemist

Copy link
Copy Markdown
Contributor

Fixes the issue described by @yuxiaomao in #902 (comment)

To simulate a call the stack (prior to pushing the return address) needs to be aligned to 16 bytes to respect the x64 calling convention, and only the return address should be pushed.

@yuxiaomao

Copy link
Copy Markdown
Collaborator

Thank you! It seems also useful even if we don't use unwind, to get a proper behavior in my sample (I don't know why timeout still works sometimes in real game project tho).

I also discovered that, timeout can be re-triggered if I drag and move UI pop-up for a while (I have heaps timeout set to 1 which normally should not be the case). On the second timeout it does not show any stack when using unwind (show full stack without unwind), but in both case the game / UI windows hang in a strange way.

@yuxiaomao yuxiaomao merged commit 92ff18c into HaxeFoundation:master Jul 1, 2026
30 checks passed
@Apprentice-Alchemist Apprentice-Alchemist deleted the ui-win-sentinel branch July 1, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants