fix(asm): rename deleteAsset operationId to archiveAsset#2
Open
dmchaledev wants to merge 1 commit into
Open
Conversation
The DELETE /assets/{asset_id} operation soft-archives assets rather than
permanently removing them. The misleading operationId causes SDK generators
to emit a deleteAsset() method that is at odds with its actual behaviour,
and risks callers avoiding the operation out of fear of data loss.
https://claude.ai/code/session_017hoUmwWaX3gAQTqJF7qcCC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DELETE /assets/{asset_id}hasoperationId: deleteAsset, but the operation does not delete — it soft-archives the asset. The summary and description already say "Archive asset" / "Marks an asset as archived", so the operationId is the only inconsistency.This matters because:
operationIdas the method name. Every generated client ships adeleteAsset()method that actually archives, which is confusing and potentially dangerous — callers may avoid it fearing permanent data loss, or call it expecting deletion.Fix
One-line rename:
deleteAsset→archiveAsset.This is a breaking change for existing generated clients that reference
deleteAssetby name, but it is the correct fix — shipping a spec with a misleading operationId pushes that breakage downstream to every consumer indefinitely.Test plan
deleteAssetoperationIdGenerated by Claude Code