Refactor adaptive forgetting factor in PDAF_set_forget / PDAF_set_forget_local#78
Merged
jjokella merged 2 commits intotsmp-pdaf-patchedfrom Apr 30, 2026
Merged
Conversation
and adapt documentation of command line input `forget` according to the new adaptive forgetting factor routines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the previous adaptive forgetting factor formula (
var_ens / (var_resid - var_obs)) with a target-variance-based approach.The new algorithm inflates the ensemble only when its spread in observation space is below the observation error standard deviation, and caps the result at 1. The
forgetinput parameter now acts as a lower bound (maximum inflation) in adaptive mode (type_forget = 1/2) rather than being unused.docs/users_guide/running_tsmp_pdaf/input_cmd.md: addedtype_forgetsection; updatedforgetsection to document fixed vs. adaptive mode.