PDAF-OMI for GRACE-DA and SM-DA#26
Merged
jjokella merged 71 commits intotsmp-pdaf-patchedfrom Apr 27, 2026
Merged
Conversation
modules are compiled first
independent of component model
by introducing `#ifdef CLMFIVE` constructs
jjokella
force-pushed
the
tsmp-pdaf-patched-omi
branch
from
9218e33 to
e87944c
Compare
needs to change for Intel/Gnu compilers
``` Error: Operand of .not. operator at (1) is INTEGER(4) ```
* Add Anne as author and bug fix in mod_read_obs.F90 * bug fix in mod_read_obs
``` Error: Arithmetic overflow converting REAL(16) to REAL(8) at (1). This check can be disabled with the option ‘-fno-range-check’ ```
…or multivariate DA
Fix for memory issue
In particular `case default` statements for various select case constructs.
Collaborator
Author
|
Updates from @s7yoewer (coming soon in branch)
|
Closed
* GRACE-DA: general documentation and documentation of input options * OMI: developer information and observation file format --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
### Notes about the Implementation Fixing `assim_*` at the beginning of the simulation in `init_pdaf.F90` based on the inputs `clmupdate_*` from the `enkfpf.par`. Fixing `assim_*` during runtime is dangerous, because the `clmupdate_*` are updated at every timestep according to the observation type in the observation file. ### Minor points in PR - Adding templates for new observation type `C` throughout the implementation. - remove `rms_obs_*` variables from `mod_assimilation` --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
`CLM:print_inc`: (integer) If set to `1`, the analysis increment (post-analysis minus prior state) is printed after each SWC update step by invoking `print_inc_clm`. `CLM:print_inc` has no effect when only TWS assimilation is active (`CLM:update_tws`), for which the increment is always printed. Default: `0`. Side note: Handling of `CLM:print_swc`, which is made unaccessible for eCLM-PDAF. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Introduce `use_omi_model` (set to value of `use_omi`) for making the `use_omi` command line input information available in the model interface routines from `interface/model`. `use_omi_model` is used to decide whether the DA statevector definition routine needs to be called at each update step according to the observation type (OMI) or not (non-OMI).
* observation input `dr` to length 2 main reason: make observation files usable for OMI and non-OMI simulations * docs: update docs for `dr`
jjokella
added a commit
to HPSCTerrSys/TSMP2
that referenced
this pull request
Apr 29, 2026
- update component model PDAF to contain HPSCTerrSys/pdaf#26 and smaller changes/bugfixes - add PDAF include path PR only affects `eCLM-*-PDAF`. --------- Co-authored-by: Yorck Ewerdwalbesloh <s7yoewer@uni-bonn.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDAF-OMI development by Yorck Ewerdwalbesloh and Anne Springer from Uni Bonn.
User
Command line switch
use_omiUser documentation: https://hpscterrsys.github.io/pdaf/users_guide/running_tsmp_pdaf/tsmp_pdaf_omi.html#omi-tsmp-pdaf-with-pdaf-omi
Developer
Developer documentation: https://hpscterrsys.github.io/pdaf/developers_guide/omi_developer_guide.html
additional files in the
interface/framework/Makefile: Modules for each observation type and callback routines.separating backward compatible code from OMI code using the
use_omiswitchcontains GRACE-DA functionality in more modular way than branch
tsmp-pdaf-patched-grace-da: