Release PDAF with -fp-model=source for consistent LESTKF results#126
Merged
Release PDAF with -fp-model=source for consistent LESTKF results#126
Conversation
https://www.intel.com/content/www/us/en/docs/fortran-compiler/developer-guide-reference/2023-0/fp-model-fp.html Comparing LST-DA data assimilation experiments using the LESTKF with PDAF-OMI and PDAF-non-OMI, differences between the experiments in the RELEASE version were encountered. The DEBUG versions of the experiments were identical. ENKF experiments were also identical. Turning the `-fp-model=precise`, experiments with the LESTKF were identical. Assumption: Floating point optimization triggering wrong results in the localization routines of PDAF.
kvrigor
approved these changes
Apr 30, 2026
jjokella
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses PDAF issue:
Turning on
-fp-model=sourceinRELEASEbuild for consistent LESTKF results.Possible drawback
Performance loss. (so far not noticed in re-running existing experiments)
Further information