2337: allow resize terminal - #2343
Open
anhtumai wants to merge 2 commits into
Open
Conversation
anhtumai
force-pushed
the
2337_allow_resize_the_drop_down_terminal_ver_2
branch
5 times, most recently
from
August 21, 2026 04:22
b00d5e2 to
93a9562
Compare
Contributor
Author
Allow resizing the drop-down terminal by dragging its bottom-edgecloses #2337 ReasonWe have Ctrl Up and Ctrl Down to resize the height of drop-down terminal, but unless users read the source code they may never discover it. Allowing users to resize by dragging bottom-edge is a discoverable and UX-friendly alternative. ImplementationAdding a thin drag handler in the bottom of drop-down terminal. When users hold the handler with cursor, it triggers an interactive resizing activity for whole window. When the button is released, the app persists final height percentage to setting, with same mechanism as Here is the demo: Screencast.From.2026-08-21.08-50-01.mp4 |
anhtumai
marked this pull request as ready for review
August 21, 2026 05:52
use mouse to resize the terminal up and down. The final height percentage will be saved to final setting.
anhtumai
force-pushed
the
2337_allow_resize_the_drop_down_terminal_ver_2
branch
from
August 21, 2026 06:17
93a9562 to
2f78cfd
Compare
…-valignment is bottom
Contributor
Author
|
@Davidy22 I have fixed all your comments in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow these steps before submitting a new Pull Request to Guake:
rebase on latest HEAD:
hack your change
to execute the code styling, checks and unit tests:
$ make style check reno-lint testdescribe your change in a slug file for automatic release note
generation, using:
and edit the created file in
releasenotes/notes/.You can see how
renoworks usingpipenv run reno --help.Please use a generic slug (eg, for translation update,
use
translation, for bugfix usebugfix,...)create new commit message
If your change is related to a GitHub issue, you can add a reference
using
#123where 123 is the ID of the issue.You can use
closes #123to have GitHub automatically close the issuewhen your contribution get merged
Semantic commit is supported (and recommended). Add one of the following
line in your commit messages: