Skip to content

2337: allow resize terminal - #2343

Open
anhtumai wants to merge 2 commits into
Guake:masterfrom
anhtumai:2337_allow_resize_the_drop_down_terminal_ver_2
Open

2337: allow resize terminal#2343
anhtumai wants to merge 2 commits into
Guake:masterfrom
anhtumai:2337_allow_resize_the_drop_down_terminal_ver_2

Conversation

@anhtumai

Copy link
Copy Markdown
Contributor

Please follow these steps before submitting a new Pull Request to Guake:

  • rebase on latest HEAD:

    $ git pull --rebase upstream master
  • hack your change

  • to execute the code styling, checks and unit tests:

    $ make style check reno-lint test
  • describe your change in a slug file for automatic release note
    generation, using:

    $ make reno SLUG=<short_name_of_my_feature>

    and edit the created file in releasenotes/notes/.
    You can see how reno works using pipenv run reno --help.

    Please use a generic slug (eg, for translation update,
    use translation, for bugfix use bugfix,...)

  • create new commit message

    $ <hack the code>
    $ git commit --all
  • If your change is related to a GitHub issue, you can add a reference
    using #123 where 123 is the ID of the issue.
    You can use closes #123 to have GitHub automatically close the issue
    when your contribution get merged

  • Semantic commit is supported (and recommended). Add one of the following
    line in your commit messages:

    # For a bug fix, uses:
    sem-ver: bugfix
    
    # For a new feature, uses:
    sem-ver: feature
    
    # Please do not use the 'breaking change' syntax (`sem-ver: api-break`),
    # it is reserved for really big reworks
    

@anhtumai anhtumai changed the title first commit 2337: allow resize terminal Aug 21, 2026
@anhtumai
anhtumai force-pushed the 2337_allow_resize_the_drop_down_terminal_ver_2 branch 5 times, most recently from b00d5e2 to 93a9562 Compare August 21, 2026 04:22
@anhtumai

anhtumai commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Allow resizing the drop-down terminal by dragging its bottom-edge

closes #2337

Reason

We have Ctrl Up and Ctrl Down to resize the height of drop-down terminal, but unless users read the source code they may never discover it. Allowing users to resize by dragging bottom-edge is a discoverable and UX-friendly alternative.

Implementation

Adding a thin drag handler in the bottom of drop-down terminal. When users hold the handler with cursor, it triggers an interactive resizing activity for whole window. When the button is released, the app persists final height percentage to setting, with same mechanism as Ctrl Up/ Ctrl Down

Here is the demo:

Screencast.From.2026-08-21.08-50-01.mp4

@anhtumai
anhtumai marked this pull request as ready for review August 21, 2026 05:52
use mouse to resize the terminal up and down. The final height
percentage will be saved to final setting.
@anhtumai
anhtumai force-pushed the 2337_allow_resize_the_drop_down_terminal_ver_2 branch from 93a9562 to 2f78cfd Compare August 21, 2026 06:17
@anhtumai

Copy link
Copy Markdown
Contributor Author

@Davidy22 I have fixed all your comments in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant