2337 allow resize the drop down terminal - #2338
Conversation
c6ebd70 to
f324c13
Compare
Allow resizing the drop-down terminal by dragging its bottom edgecloses #2337 SummarySimilar to Windows Terminal, this lets you resize Guake's drop-down window by dragging its bottom edge — handy for temporarily expanding the terminal to read long command output without leaving the drop-down view.
Notes
Testing
|
3b42820 to
65717ec
Compare
|
Demo of my PR: Screencast.From.2026-08-03.17-31-56.mp4 |
|
I notice from both my testing and your video that this change introduces an unnecessary titlebar. That's going to have to get cleaned up before I merge this. |
|
Thank you for your respone. I will look at it tonight or this weekend |
808b81f to
6c9b2f6
Compare
|
@Davidy22 I have fixed the code. Screencast.From.2026-08-15.20-49-42.mp4 |
6c9b2f6 to
f93a747
Compare
|
About the title bar, actually I prefer to keep it, because it has options to: Move to monitor (Up/Down/Left/Right). So we can move the Guake terminal to other places, not stuck in one place. What do you think about this @Davidy22 ?
If you agree, I will keep the titlebar, since it improves user experience a lot Another solution is to make another issue to fix: Move Guake terminal to wherever cursor last clicks, but it will be much harder to do than just enabling the titlebar by setting: decorated=True |
@Davidy22 sorry for direct ping. But can you give your feedback here? |
Davidy22
left a comment
There was a problem hiding this comment.
Adding a title bar changes the program quite substantially, is out of scope for this PR, and jars with how it's supposed to be a panel that pulls down from the top.
Flagged things I noticed, also the temporary override mechanism's a point of discussion. Size changes not being reflected in the preferences menu is going to be a bit unintuitive. Also need to consider what merits usage of the temporary settings, why would dragging the window edge count for a temporary change, but CTRL+up/down doesn't?
I would lean heavy towards cutting the temporary settings mechanism and just having the window edge dragging alter the general window size setting. If you want to make a case for doing it this way, at the very least the window size keyboard shortcuts fulfil a very similar role to this and should also use the same mechanism.
|
|
||
| # Window is undecorated (no WM title bar/borders), so provide a thin | ||
| # drag handle at the bottom edge to let users resize it manually. | ||
| # This is for issue: https://github.com/Guake/guake/issues/2337 |
There was a problem hiding this comment.
Don't put issue numbers in comments, just describe what the code does.
| self.prev_accel_search_terminal_time = 0.0 | ||
|
|
||
| # holds the GLib source id for the pending resize-debounce timeout | ||
| # used to capture resizing activities for https://github.com/Guake/guake/issues/2337 |
| <object class="GtkMenu" id="tray-menu"> | ||
| <property name="visible">True</property> | ||
| <property name="can_focus">False</property> | ||
| <property name="can-focus">False</property> |
There was a problem hiding this comment.
This is a convention change to go with the glade version bump I presume?
| exclude: COPYING | ||
| - repo: https://github.com/PyCQA/flake8.git | ||
| rev: 3.9.2 | ||
| rev: 7.3.0 |
There was a problem hiding this comment.
Don't change our linter versions. Out of scope, do this in another PR.
Thank you . I will modify the logic to align with existing implementation |
…o that users can drag the bottom bar of drop-down terminal up and down to adjust its height
… can hide titlebar like before, and create a custom GTK event box in the bottom so users can drag the bottom bar up and down
f93a747 to
b953ed2
Compare

Please follow these steps before submitting a new Pull Request to Guake:
rebase on latest HEAD:
hack your change
to execute the code styling, checks and unit tests:
$ make style check reno-lint testdescribe your change in a slug file for automatic release note
generation, using:
and edit the created file in
releasenotes/notes/.You can see how
renoworks usingpipenv run reno --help.Please use a generic slug (eg, for translation update,
use
translation, for bugfix usebugfix,...)create new commit message
If your change is related to a GitHub issue, you can add a reference
using
#123where 123 is the ID of the issue.You can use
closes #123to have GitHub automatically close the issuewhen your contribution get merged
Semantic commit is supported (and recommended). Add one of the following
line in your commit messages: