fix[cartesian]: percision issue with dace math functions#2595
Open
romanc wants to merge 5 commits into
Open
Conversation
`log10(x)` will always be in double precision, regardless of `GT4PY_LITERAL_FLOAT_PRECISION`. With this PR, we are deferring to `dace.math.log10`, which is a templated version that respects the floating point precision.
romanc
force-pushed
the
romanc/fix-log10-precision
branch
from
00a7a94 to
901b57e
Compare
Contributor
Author
|
wait - there's more. In particular, I stumbled across |
romanc
force-pushed
the
romanc/fix-log10-precision
branch
from
170a1a7 to
91de511
Compare
romanc
force-pushed
the
romanc/fix-log10-precision
branch
from
91de511 to
1abd6c7
Compare
romanc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Several math functions, e.g.
log10(x), do not respectGT4Py_LITERAL_FLOAT_PRECISIONin the dace backend.The issue is caused by a combination of dace's code generation and the C/C++ standard library history. In C,
log10(x)is defined to operate in double precision. The single-precision equivalent is calledlog10f(x), see here.In C++, there is
std::log10(x), which is a templated version that computes in either single- or double-precision depending on the argument. DaCe exposes access to those templated versions throughdace/math.h. Some function were missing and are being patched with spcl/dace#2364. Building on that PR in DaCe, this PR uses the newly exposed fuctions in the cartesian DaCe backends.Requirements
N/A