Add guide lines feature #3644
Open
Add guide lines feature #3644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjgdh
changed the title
Contributor
|
It still looks strange when rotating a document with guides in: rotating_document_with_guide.mp4Also the snapping doesn't work when the document is rotated. |
0HyperCube
reviewed
Jan 22, 2026
Contributor
0HyperCube
left a comment
0HyperCube
left a comment
There was a problem hiding this comment.
Seems to work well; I have a few suggestions for the code structure. I won't comment on the JS changes.
Please mark the PR as «Ready to review» when you are happy with it.
editor/src/messages/portfolio/document/overlays/guide_overlays.rs
Outdated
Show resolved
Hide resolved
editor/src/messages/portfolio/document/overlays/guide_overlays.rs
Outdated
Show resolved
Hide resolved
editor/src/messages/portfolio/document/document_message_handler.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: James Lindsay <78500760+0HyperCube@users.noreply.github.com>
Co-authored-by: James Lindsay <78500760+0HyperCube@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds feature for guide lines that can be dragged from the rulers to help with alignment .closes #2601
image of guide lines: