Skip to content

Payroll Filter UI#301

Merged
TeddyScript101 merged 4 commits into
mainfrom
egharvey/feature/payroll-filter-ui
Apr 30, 2026
Merged

Payroll Filter UI#301
TeddyScript101 merged 4 commits into
mainfrom
egharvey/feature/payroll-filter-ui

Conversation

@egharvey
Copy link
Copy Markdown
Collaborator

Overview

This PR adds the payroll history screen with the ability to view the user's payroll history and filter it by a number of fields. Supports loading, loaded and error states and validates filter inputs. As the APIhas not yet been implemented, this is using dummy data at present. I tried to upload screenshots, but GitHub was not happy with that.

Known Issues

  • While translation ready, currently only supports English (I only know English)
  • API is not implemented, logic was prepared in comments, but is likely not complete, API result may come out different than expected.
  • There is a massive if else series in PayrollScreen.tsx, given my current knowledge of TypeScript, this was the best way I could think to do this, I am open to feedback on this.

@egharvey
Copy link
Copy Markdown
Collaborator Author

Branch now implements payroll api.

@TeddyScript101
Copy link
Copy Markdown
Collaborator

  1. Please provide screenshots for your PR next time. I have attached the screenshots here this time.
  2. I will create a ticket for the multilingual support, no worries.
  3. It is found that the integration of the API is not perfect (Failed to load payroll history), but your task is mainly for the frontend. I will handle this matter.
image image image

@TeddyScript101 TeddyScript101 merged commit dde37a2 into main Apr 30, 2026
2 checks passed
@TeddyScript101 TeddyScript101 deleted the egharvey/feature/payroll-filter-ui branch April 30, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants