Fix attendance check-in and check-out validation flow#298
Open
Fix attendance check-in and check-out validation flow#298
Conversation
Collaborator
Author
|
Note: backend lint issues identified in CI have been cleaned up and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the attendance check-in/check-out flow so it works with the current data model and validates guard assignment and shift location correctly.
What changed
aligned
shiftattendance.controller.jswith the currentShiftAttendanceschemashift/guardinstead of oldshiftId/guardIdclockIn/clockOutscheduledStart/scheduledEndvalidate guard is assigned to the shift before check-in/check-out
validate shift has stored
location.latitude/location.longitudevalidate guard is within 100m radius before check-in
prevent duplicate check-in
prevent duplicate check-out
fix attendance history query to use
guardand sort byclockInTesting
Tested manually via Swagger:
201400 Already checked in200400 Already checked out400 Not within shift radius (100m)Notes
ShiftAttendanceschema does not store check-in/check-out GeoJSON fields, so this PR aligns with the existing model rather than extending it