Skip to content

Stop login retry loop after successful authentication - #235

Open
ameel wants to merge 1 commit into
Googolplexed0:mainfrom
ameel:fix/stop-retrying-successful-login
Open

Stop login retry loop after successful authentication#235
ameel wants to merge 1 commit into
Googolplexed0:mainfrom
ameel:fix/stop-retrying-successful-login

Conversation

@ameel

@ameel ameel commented Sep 9, 2026

Copy link
Copy Markdown

Successful authentication is repeated when RETRY_ATTEMPTS is greater than zero because the login loop has no success exit. With the default retry count of one, Zotify creates a second Spotify session immediately after the first session succeeds.

This adds a break after login() returns successfully. Connection failures still follow the existing retry behavior.

Validation:

  • regression test confirms one login call after success;
  • regression test confirms a failed login is still retried;
  • performed a complete track download using the saved Spotify credentials after applying the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant