google patch[deps]: fix release-3.13.0-gmp vulnerabilities - #365
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Go version to 1.26.0 in the root go.mod, bumps several golang.org/x dependencies, and updates the Go build and base images in Dockerfile.google. The reviewer noted that updating the Go version in the root go.mod without updating the other go.mod files in the repository will cause the check-go-mod-version CI check to fail, and requested that all other go.mod files be updated for consistency.
| module github.com/prometheus/prometheus | ||
|
|
||
| go 1.25.0 | ||
| go 1.26.0 |
There was a problem hiding this comment.
Bumping the Go version to 1.26.0 in the root go.mod without updating the other go.mod files in the repository (such as documentation/examples/remote_storage/go.mod, web/ui/mantine-ui/src/promql/tools/go.mod, and internal/tools/go.mod) causes the check-go-mod-version CI job to fail. The script scripts/check-go-mod-version.sh requires all go.mod files in the repository to have matching Go versions. Please update all other go.mod files to go 1.26.0 to maintain consistency and pass the CI checks.
1a6e003 to
ee5a690
Compare
Signed-off-by: avilevy <avilevy@google.com>
ee5a690 to
13e3324
Compare
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
Hope 1.26 move will not create further issues. 3.x is fine, but I'm worried on other fronts.
2 participants
Updating Go and image vulnerabilities using