Add CODEOWNERS for component ownership#1085
Open
erain wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Open
Add CODEOWNERS for component ownership#1085erain wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
erain wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
.github/CODEOWNERSfile for the top-level components in this monorepo/custom-metrics-stackdriver-adapter/to@juli4n/event-exporter/to@courageJand@erain@erainas the default owner for all other areas for nowWhy
This lets GitHub route pull requests to the right reviewers based on the paths changed.
Follow-up
To make ownership enforceable at merge time, the repo still needs branch protection with
Require review from Code Owners, and listed owners must have write access to the repository.