feat(admin-ui): implement responsive mobile layout for Sessions and Authentication modules (#2960) - #2961
Conversation
…uthentication modules (#2960) Signed-off-by: faisalsiddique4400 <faisalsiddique10886@gmail.com>
|
Warning Review limit reached
Next review available in: 22 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mo-auto
added
comp-admin-ui
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@admin-ui/plugins/auth-server/components/Authentication/Acrs/AcrsForm.tsx`:
- Around line 458-471: Update AcrsForm so every LDAP field, toggle, and
script-property input is disabled or read-only when isMobile is true, including
the controls near addConfigProperty and the referenced ranges. Prevent the Form
submission path from invoking formik.handleSubmit on mobile, so Enter cannot
open GluuCommitDialog. Add a regression test verifying mobile controls are
non-editable and submission is blocked.
In
`@admin-ui/plugins/auth-server/components/Authentication/AgamaFlows/AgamaFlows.tsx`:
- Line 88: Normalize searchPattern once by deriving a trimmed search value or
non-empty search flag, then use it consistently in query-mode selection, query
parameters, visibleData filtering and pagination, and totalItems calculation.
Ensure whitespace-only input follows the unfiltered paginated path rather than
fetching and returning all rows.
In
`@admin-ui/plugins/auth-server/components/Authentication/DefaultAcr/DefaultAcr.tsx`:
- Around line 209-225: Update the GluuSelectRow usage in the DefaultAcr
component to pass disabled={isMobile}, making the mobile Default ACR selector
read-only while preserving its existing behavior on desktop.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 2794f77e-ddf8-45f6-a22d-d303b341b6a0
📒 Files selected for processing (20)
admin-ui/app/components/GluuFilterPopover/GluuFilterPopover.style.tsadmin-ui/app/components/GluuFilterPopover/GluuFilterPopover.tsxadmin-ui/app/constants/ui.tsadmin-ui/plugins/auth-server/components/Authentication/Acrs/Acrs.tsxadmin-ui/plugins/auth-server/components/Authentication/Acrs/AcrsForm.style.tsadmin-ui/plugins/auth-server/components/Authentication/Acrs/AcrsForm.tsxadmin-ui/plugins/auth-server/components/Authentication/AgamaFlows/AgamaFlows.style.tsadmin-ui/plugins/auth-server/components/Authentication/AgamaFlows/AgamaFlows.tsxadmin-ui/plugins/auth-server/components/Authentication/AgamaFlows/AgamaProjectConfigModal.style.tsadmin-ui/plugins/auth-server/components/Authentication/AgamaFlows/constants.tsadmin-ui/plugins/auth-server/components/Authentication/Aliases/Aliases.tsxadmin-ui/plugins/auth-server/components/Authentication/Authentication.tsxadmin-ui/plugins/auth-server/components/Authentication/DefaultAcr/DefaultAcr.style.tsadmin-ui/plugins/auth-server/components/Authentication/DefaultAcr/DefaultAcr.tsxadmin-ui/plugins/auth-server/components/Authentication/styles/Authentication.style.tsadmin-ui/plugins/auth-server/components/OidcClients/__tests__/components/ClientWizardForm.test.tsxadmin-ui/plugins/auth-server/components/Sessions/components/SessionDetailPage.tsxadmin-ui/plugins/auth-server/components/Sessions/components/SessionListPage.tsxadmin-ui/plugins/auth-server/components/Sessions/components/styles/SessionListPage.style.tsadmin-ui/plugins/auth-server/components/Sessions/types/sessionTypes.ts
Signed-off-by: faisalsiddique4400 <faisalsiddique10886@gmail.com>
|
3 participants
feat(admin-ui): implement responsive mobile layout for Sessions and Authentication modules (#<issue_number>)
Summary
This PR continues the Admin UI mobile redesign by implementing responsive, view-only layouts for the Sessions and Authentication modules.
The update optimizes both modules for phone and small-tablet viewports by introducing mobile-specific view-only behavior, improving search and filtering, adopting the shared responsive detail grid, standardizing layouts and spacing, and aligning all mobile breakpoints with the shared responsive constants. Desktop and tablet layouts and functionality remain unchanged.
Fix Summary
MOBILE_MEDIA_QUERYconstant to ensure consistent responsive behavior across CSS and JavaScriptVerification
passes successfully.
🔗 Ticket
Closes: #<issue_number>
Summary by CodeRabbit
New Features
Bug Fixes