Add Windows regression test for foreign-owned paths - #2961
Merged
Conversation
Sebastian Thiel (Byron)
force-pushed
the
gix-sec-for-admins
branch
from
September 2, 2026 03:41
9a896ff to
9614c11
Compare
Sebastian Thiel (Byron)
marked this pull request as ready for review
September 2, 2026 03:45
Sebastian Thiel (Byron)
force-pushed
the
gix-sec-for-admins
branch
from
September 2, 2026 03:48
9614c11 to
9560900
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9614c11ddd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
<!-- agent --> Protect the `gix-sec` ownership check against treating arbitrary paths as owned by an administrator. The test independently reads the path owner and current user SIDs before asserting reduced trust, so it does not rely on the function under test to establish its precondition. Allow `GIX_TEST_FOREIGN_OWNED_PATH` to select a controlled fixture. Otherwise, probe well-known Windows locations and skip cleanly when the environment has no readable foreign-owned candidate. Validated with the automatic `C:\Users\Public` fallback, a `C:\Windows` override, and `cargo test -p gix-sec`. Assisted-by: GPT 5.6 Co-authored-by: GPT 5.6 <codex@openai.com>
Sebastian Thiel (Byron)
force-pushed
the
gix-sec-for-admins
branch
from
September 2, 2026 03:52
9560900 to
5e6a27b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
Protect the
gix-secownership check against treating arbitrary paths as owned by an administrator. The test independently reads the path owner and current user SIDs before asserting reduced trust, so it does not rely on the function under test to establish its precondition.Allow
GIX_TEST_FOREIGN_OWNED_PATHto select a controlled fixture. Otherwise, probe well-known Windows locations and skip cleanly when the environment has no readable foreign-owned candidate.Validated with the automatic
C:\Users\Publicfallback, aC:\Windowsoverride, andcargo test -p gix-sec.