Skip to content

fix(gix): find bundled signature programs on Windows - #2958

Merged
Sebastian Thiel (Byron) merged 1 commit into
mainfrom
sign-on-windows
Sep 2, 2026
Merged

fix(gix): find bundled signature programs on Windows#2958
Sebastian Thiel (Byron) merged 1 commit into
mainfrom
sign-on-windows

Conversation

@Byron

@Byron Sebastian Thiel (Byron) commented Sep 1, 2026

Copy link
Copy Markdown
Member

Tasks

  • refackiew

Git for Windows makes its bundled gpg, gpgsm, and ssh-keygen available
by prepending installation directories to PATH. Gitoxide can run outside that
prepared environment, so bare defaults may not resolve.

Use gix_path::env::installation_program() for unconfigured defaults on Windows
and retain the bare name as fallback. Explicit configuration and non-Windows
behavior stay unchanged.

<!-- agent -->
Git for Windows makes its bundled `gpg`, `gpgsm`, and `ssh-keygen` available
by prepending installation directories to `PATH`. Gitoxide can run outside that
prepared environment, so bare defaults may not resolve.

Use `gix_path::env::installation_program()` for unconfigured defaults on Windows
and retain the bare name as fallback. Explicit configuration and non-Windows
behavior stay unchanged.

Assisted-by: Codex <codex@openai.com>
Co-authored-by: GPT 5.6 <codex@openai.com>
@Byron
Sebastian Thiel (Byron) merged commit c16300c into main Sep 2, 2026
32 checks passed
@Byron
Sebastian Thiel (Byron) deleted the sign-on-windows branch September 2, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant