error conversion review - #2949
Draft
Sebastian Thiel (Byron) wants to merge 1 commit into
Draft
Conversation
<!-- agent --> Add opt-in final-symlink resolution for callers that need Git default lockfile behavior while retaining the existing no-follow API for loose references. Resolve again before each retry and retain the target whose lock was actually acquired. Append the lock suffix directly to OsString values so non-UTF-8 resource names remain byte-exact. Retain each original resource path instead of reconstructing it from the lock filename, avoiding panics for dotfile locks. Allow symlink-aware callers to adjust lock permissions after the process umask has been applied, so shared-repository modes can grant the intended access. Assisted-by: GPT 5.6 Co-authored-by: GPT 5.6 <codex@openai.com>
Sebastian Thiel (Byron)
force-pushed
the
error-conversion-review
branch
from
August 28, 2026 15:26
f14a381 to
0aecff9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #2944
Tasks
Later Tasks
36 error-removal commits to go.