Conversation
Merge pull request #82 from GfSE/main
Outdated and creating a merge conflict
Outdated and creating merge conflicts.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the GitHub Pages documentation/design artifacts to reflect the CASCaRA naming and refreshed “Configuration Options / Ontology-based Applications” content.
Changes:
- Renames landing-page title/header and updates “Further Information” links to CASCaRA resources.
- Updates design index navigation (replacing the former “PIG App” entry) and refreshes the “Ontology-based Applications” HTML/SpecIF/ArchiMate exports.
- Adds/adjusts README pointers for where rendered HTML documentation lives.
Reviewed changes
Copilot reviewed 11 out of 50 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/index.html | Updates project naming to CASCaRA and revises “Further Information” section links. |
| docs/design/index.html | Updates design navigation links (replacing “PIG App” entry). |
| docs/design/PIG-App/index.html | Removes generated PIG App design HTML page. |
| docs/design/Ontology-based Applications/index.html | Replaces generated Ontology-based Applications HTML export with updated structure/content. |
| design/PIG App/8_HTML/README.md | Removes README that pointed to the PIG App HTML representation. |
| design/Ontology-based Applications/8_HTML/README.md | Updates README pointer for the ontology-driven application concept HTML. |
| design/Ontology-based Applications/3_SpecIF/Ontology-based Applications.specif | Updates SpecIF export (schema/generator/version/content refresh). |
| design/Ontology-based Applications/1_Source/Ontology-based Applications.xml | Updates source XML terminology (CASCaRA App/metamodel) and fixes a typo. |
| design/Ontology-based Applications/1_Source/Ontology-based Applications.archimate.bak | Updates ArchiMate backup naming/terminology. |
| design/Ontology-based Applications/1_Source/Ontology-based Applications.archimate | Updates ArchiMate source naming/terminology. |
| design/CASCaRA-Reference-Implementation/8_HTML/README.md | Adds README pointing to the CASCaRA Reference Implementation rendered docs. |
Comments suppressed due to low confidence (4)
docs/design/index.html:1
- The second link contains a literal space in the URL (
./Ontology-based Applications/). While browsers may auto-encode it, GitHub Pages/static hosting can be sensitive and it’s error-prone. Consider URL-encoding the space (Ontology-based%20Applications) or renaming the folder to avoid spaces and updating links accordingly.
docs/index.html:1 - Grammar fix recommended:
reference implementation' executableshould bereference implementation's executable(or rephrase to avoid the possessive).
docs/index.html:1 - The document language is set to German (
lang=\"de\"), but the page content shown here is English. For correct screen-reader pronunciation and better SEO, updatelangto match the actual content language (e.g.,en) or make the content consistently German.
docs/index.html:1 - The PR description says this revision has already been pulled into
main, but this PR still shows substantive diffs. Please either update the PR description to reflect what remains to be merged, or close the PR if it’s truly already included inmain.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1 +1 @@ | |||
| For the HTML representation of the PIG App design, see the documentation folder of this repository: https://github.com/GfSE/CASCaDE-Reference-Implementation/tree/main/docs/design/PIG-App. No newline at end of file | |||
| For the HTML representation of the ontology-driven application concept, see the documentation folder of this repository: https://github.com/GfSE/CASCaDE-Reference-Implementation/tree/main/docs/design/CASCaRA-Reference-Implementation. No newline at end of file | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update design: Configuration Options.
(This revision has been already pulled by 'main')