Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #1378 +/- ##
=====================================
Coverage ? 37.94%
=====================================
Files ? 395
Lines ? 30159
Branches ? 0
=====================================
Hits ? 11443
Misses ? 18716
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Is the dialog coming from StreamChat? |
🎯 Goal
In light mode the feedback dialog showed as a large white square covering almost the whole screen, instead of the rounded card it shows in dark mode.
🛠 Implementation details
The dialog wrapped its card in a
Scaffold, which fills the dialog's whole area withscaffoldBackgroundColor(backgroundApp). In light mode that is the same white as the card, so the card's edges disappeared; in dark mode it is black like the barrier, so it went unnoticed.The
Scaffoldis replaced by a transparentMaterial, which still gives the text input its Material ancestor.A dialog that is already open does not follow a light/dark switch. That comes from
StreamChatwrapping the route in its ownTheme, and is fixed in GetStream/stream-chat-flutter onfix/stream-chat-theme-dialogs.🎨 UI Changes
🧪 Testing
In light and dark mode, open the dialog from the call's ⋮ menu → Provide feedback, and by leaving a call. It shows as a rounded card over the dimmed screen.
☑️Contributor Checklist
General
☑️Reviewer Checklist
🤖 Generated with Claude Code