Skip to content

fix(samples): stop the feedback dialog filling the screen in light mode - #1378

Open
renefloor wants to merge 1 commit into
v2from
fix/feedback-dialog-light-mode
Open

renefloor wants to merge 1 commit into
v2from
fix/feedback-dialog-light-mode

Conversation

@renefloor

@renefloor renefloor commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Goal

In light mode the feedback dialog showed as a large white square covering almost the whole screen, instead of the rounded card it shows in dark mode.

🛠 Implementation details

The dialog wrapped its card in a Scaffold, which fills the dialog's whole area with scaffoldBackgroundColor (backgroundApp). In light mode that is the same white as the card, so the card's edges disappeared; in dark mode it is black like the barrier, so it went unnoticed.

The Scaffold is replaced by a transparent Material, which still gives the text input its Material ancestor.

A dialog that is already open does not follow a light/dark switch. That comes from StreamChat wrapping the route in its own Theme, and is fixed in GetStream/stream-chat-flutter on fix/stream-chat-theme-dialogs.

🎨 UI Changes

Before After
image after_leave_light
image after_leave_dark

🧪 Testing

In light and dark mode, open the dialog from the call's ⋮ menu → Provide feedback, and by leaving a call. It shows as a rounded card over the dimmed screen.

☑️Contributor Checklist

General

  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#flutter-team) (required)
  • PR is linked to the GitHub issue it resolves

☑️Reviewer Checklist

  • Sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • All code we touched has new or updated Documentation

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 300f91f1-ee82-4b66-afa4-66a051a91929

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v2@002747a). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1378   +/-   ##
=====================================
  Coverage      ?   37.94%           
=====================================
  Files         ?      395           
  Lines         ?    30159           
  Branches      ?        0           
=====================================
  Hits          ?    11443           
  Misses        ?    18716           
  Partials      ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@renefloor
renefloor changed the base branch from main to v2 September 24, 2026 14:00
@renefloor
renefloor marked this pull request as ready for review September 24, 2026 14:02
@renefloor
renefloor requested a review from a team as a code owner September 24, 2026 14:02
@xsahil03x

Copy link
Copy Markdown
Member

Is the dialog coming from StreamChat?

@Brazol Brazol added the v2 label Sep 25, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants