Skip to content

feat(ui, samples): add a badge count to the call buttons - #1376

Open
renefloor wants to merge 6 commits into
v2from
fix/badge-color-update
Open

renefloor wants to merge 6 commits into
v2from
fix/badge-color-update

Conversation

@renefloor

@renefloor renefloor commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • CallControlButton, CallFeatureButton and StreamCallButtonBadge take one badge, a sealed CallControlBadge, in place of showErrorBadge. CallControlErrorBadge draws the error badge; CallControlNotificationBadge draws a count as a StreamBadgeNotification, optionally in a StreamBadgeNotificationType. A zero count draws nothing.
  • StreamParticipantsButton (and so the lobby) uses it with the neutral badge instead of badging itself in accentSuccess.
  • The sample app's BadgedCallOption is removed; its participants and chat buttons pass a CallControlNotificationBadge, and the participants count is neutral.

Testing

  • New StreamCallButtonBadge tests for the count and its type.
  • The participants and lobby button tests tap the StreamButton, since the badge's box fills the test surface when the button is pumped on its own.
  • No golden in the lobby shows a count.

🤖 Generated with Claude Code
image
image

CallControlButton and CallFeatureButton take a badgeCount, drawn through
StreamCallButtonBadge in the design system's badge colour.
StreamParticipantsButton uses it, and the sample app's BadgedCallOption is
replaced by it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f69ac0c5-c4c9-4463-b886-9ea81b606266

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@renefloor
renefloor marked this pull request as ready for review September 24, 2026 12:40
@renefloor
renefloor requested a review from a team as a code owner September 24, 2026 12:40
@renefloor renefloor added the v2 label Sep 24, 2026
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.28571% with 10 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (v2@002747a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ib/src/call_controls/stream_call_button_badge.dart 50.00% 10 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1376   +/-   ##
=====================================
  Coverage      ?   37.93%           
=====================================
  Files         ?      395           
  Lines         ?    30171           
  Branches      ?        0           
=====================================
  Hits          ?    11445           
  Misses        ?    18726           
  Partials      ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

renefloor and others added 3 commits September 25, 2026 08:17
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…led CallControlBadge

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant