fix: resolve CI build failures across all modules#24
Open
GalaxySciTech wants to merge 3 commits intomasterfrom
Open
fix: resolve CI build failures across all modules#24GalaxySciTech wants to merge 3 commits intomasterfrom
GalaxySciTech wants to merge 3 commits intomasterfrom
Conversation
Replace direct PageRequest constructor calls with PageRequest.of() because the constructor is protected in Spring Data 3.x. Co-authored-by: Galaxy <GalaxySciTech@users.noreply.github.com>
- findOne(id) -> findById(id).orElse(null) - delete(id) -> deleteById(id) - delete(list) -> deleteAll(list) - save(list) -> saveAll(list) - PageRequest(page, size) -> PageRequest.of(page, size) - PageRequest(page, size, sort) -> PageRequest.of(page, size, sort) Applied across 11 service implementation files. Co-authored-by: Galaxy <GalaxySciTech@users.noreply.github.com>
- Migrate Swagger 2 annotations (io.swagger.annotations) to OpenAPI 3 (io.swagger.v3.oas.annotations.media.Schema) in wallet-entity po/vo files - Fix QueryDslPredicateExecutor -> QuerydslPredicateExecutor (Spring Data 3.x rename) across all 11 repository interfaces - Add explicit eos4j dependency to wallet-entity and wallet-hsm for io.eblock.eos4j.api.vo.SignParam resolution - Remove unused SignParam import from SignUsdtPo.kt - Use java-library plugin with api scope for wallet-entity and wallet-common to expose transitive QueryDSL and entity dependencies - Add commons-codec and bitcoinj-core dependencies to wallet-common - Fix RestTemplateBuilder API (connectTimeout -> setConnectTimeout) for Spring Boot 3.x - Fix BizException constructor call in PushComponent (ErrorCode -> ErrorCode.code) - Fix TrxApi ECKey.findRecoveryId to manual recovery ID computation for bitcoinj 0.14.7 Co-authored-by: Galaxy <GalaxySciTech@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CI build failure reported in actions/runs/23904371445. The
wallet-entity:compileKotlintask was failing due to multiple categories of unresolved references. This PR also fixes pre-existing compilation errors inwallet-common,wallet-hsm,wallet-webapi, andwallet-taskmodules that were masked because the build failed early onwallet-entity.Changes
Swagger 2 → OpenAPI 3 Migration (wallet-entity)
io.swagger.annotations.ApiModel/ApiModelPropertywithio.swagger.v3.oas.annotations.media.Schemain:GetTransactionPo.kt,LoginPo.kt,RegisteredPo.kt,SendPo.kt,TransferPo.ktCustomerInfoVo.kt,DepositEosVo.kt,TransferRecordVo.ktQueryDSL Spring Data 3.x Fix (wallet-entity)
QueryDslPredicateExecutor→QuerydslPredicateExecutor(lowercase 'dsl') across all 11 repository interfaces to match Spring Data 3.x APIDependency Resolution
io.github.qyvlik:io.eblock.eos-eos4j:1.0.1dependency towallet-entityandwallet-hsm(transitive from tokencore via JitPack was not resolving)commons-codec:commons-codec:1.16.0andorg.bitcoinj:bitcoinj-core:0.14.7towallet-commonjava-libraryplugin towallet-entityandwallet-common, changed QueryDSL and project dependencies toapiscope so transitive types are accessible to downstream modulesSpring Data 2.x → 3.x API Migration (wallet-common)
repository.findOne(id)→repository.findById(id).orElse(null)(15 occurrences)repository.delete(id)→repository.deleteById(id)(7 occurrences)repository.delete(list)→repository.deleteAll(list)(1 occurrence)repository.save(list)→repository.saveAll(list)(3 occurrences)PageRequest(page, size)→PageRequest.of(page, size)(6 occurrences)Other Fixes (wallet-common)
RestTemplateBuilder.connectTimeout()→.setConnectTimeout()for Spring Boot 3.xBizExceptionconstructor mismatch inPushComponent.ktECKey.findRecoveryId()with manual recovery ID computation inTrxApi.kt(bitcoinj 0.14.7 compatibility)SignParamimport fromSignUsdtPo.ktVerification
Full project builds successfully with
./gradlew build -x test --no-daemon— all modules compile cleanly.