Skip to content

include doc in default groups when building docs, remove uv sync#44

Merged
chrisdicaprio merged 4 commits intomainfrom
doc-default-group
Apr 13, 2026
Merged

include doc in default groups when building docs, remove uv sync#44
chrisdicaprio merged 4 commits intomainfrom
doc-default-group

Conversation

@chrisdicaprio
Copy link
Copy Markdown
Collaborator

  • doc group was missing from default groups when building documentation
  • extraneous uv sync in doc build workflow was causing a re-install of the package w/o the optional dependencies

@chrisdicaprio chrisdicaprio requested review from chrisbc and voj April 13, 2026 23:00
Copy link
Copy Markdown
Collaborator

@voj voj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question

Comment thread .github/workflows/python-deploy-docs-uv.yml Outdated
Add build-only input to python-deploy-docs and python-deploy-docs-uv
reusable workflows so the upload/deploy steps can be skipped in CI.

Create python-deploy-docs-test.yml and python-deploy-docs-test-uv.yml
that call the reusable workflows with build-only: true to validate the
mkdocs build without attempting GitHub Pages deployment.

Add mkdocs fixtures (mkdocs.yml, docs/index.md, doc dependency group)
to both samplePythonProject and samplePythonProjectUv.
The environment protection rules block PR branches from deploying,
which causes the test workflows to fail even though deploy steps are
skipped. Make the environment declaration conditional on build-only.
Copy link
Copy Markdown
Member

@chrisbc chrisbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @chrisdicaprio thanks

@chrisdicaprio chrisdicaprio merged commit 395dd43 into main Apr 13, 2026
28 checks passed
@chrisdicaprio chrisdicaprio deleted the doc-default-group branch April 13, 2026 23:28
Copy link
Copy Markdown
Collaborator

@voj voj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants