Repository navigation
ru: the five keys the catalogue is missing (Play Version, playback speed) - #1029
Merged
Merged
Conversation
… speed x2) The Russian catalogue (#1006) landed after the Play Version and playback speed strings, so plx_platform's build.rs refuses main ("localization catalogs: 5 error(s)") and every cargo build on main fails: CI and Simulator CI are red at b835afb. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
"Скорость воспроизведения" measured 674 px against MENU_MAX_W 650, so the more_menu fit gates failed in every language run. One word, like the "Качество" row beside it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tiper
added a commit
to tiper/fin-native
that referenced
this pull request
Oct 25, 2026
Brings in the Russian catalogue fix (GLinnik21#1029) so CI builds on a green base. Signed-off-by: Tiago Pereira <1698241+tiper@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red at b835afb. The Russian catalogue (#1006) landed after the Play Version and playback speed strings, soplx_platform'sbuild.rsrefuses the build. CI'smake check-cargo-unit-hostsimlog shows:Every cargo build on
mainfails until this lands. CI and Simulator CI are both red.browse.detail.play_versionbrowse.menu.play_versionbrowse.menu.play_version_titlewidgets.menu.speedwidgets.speed.normal"Смотреть" follows the catalogue's own Play (
browse.detail.play,play_start). "Обычная" agrees with «скорость». The speed row is one word, like "Качество" beside it: "Скорость воспроизведения" measured 674 px againstMENU_MAX_W650 and failed themore_menufit gates.Verified: with these five keys, a full ARM build and the
plx_base,plx_gfxand application crate lib tests pass in a worktree cut from b835afb. CI is the gate for the rest.🤖 Generated with Claude Code