You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks good to me! although, hm, not sure what happened to package-lock.json.
(Assuming this is what you're asking) When you run npm install it will update the dependencies in package-lock.json to the most recent versions that are compatible with what you have already installed. To avoid that one should npm ci instead (which, tbh, I maybe should start doing).
Looks good to me! although, hm, not sure what happened to package-lock.json.
(Assuming this is what you're asking) When you run npm install it will update the dependencies in package-lock.json to the most recent versions that are compatible with what you have already installed. To avoid that one should npm ci instead (which, tbh, I maybe should start doing).
I understand that, it's just I'm not sure how we ended up in the position where package-lock.json has to be manually fixed again.
I don't remember a lot about this branch, but generally what happens is:
PR#1 comes in with an updated package-lock.json
PR#2 comes in with an updated package-lock.json
PR#1 (and its package-lock.json) gets merged into main
PR#2's package-lock.json now conflicts with the one on main
Every time a new package-lock.json hits main, it's likely to conflict with the ones from open PRs because the dependencies versions within have a tendency to change in incompatible ways. The solution would really be to only commit intentional changes to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes #12