Skip to content

Improve error handling on Authproto#19

Merged
essential-randomness merged 2 commits intomainfrom
authproto-idk
Feb 8, 2026
Merged

Improve error handling on Authproto#19
essential-randomness merged 2 commits intomainfrom
authproto-idk

Conversation

@essential-randomness
Copy link
Member

Supercedes #12

@siotle siotle mentioned this pull request Feb 5, 2026
Copy link
Collaborator

@siotle siotle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
although, hm, not sure what happened to package-lock.json.

@essential-randomness
Copy link
Member Author

Looks good to me! although, hm, not sure what happened to package-lock.json.

(Assuming this is what you're asking) When you run npm install it will update the dependencies in package-lock.json to the most recent versions that are compatible with what you have already installed. To avoid that one should npm ci instead (which, tbh, I maybe should start doing).

@siotle
Copy link
Collaborator

siotle commented Feb 8, 2026

Looks good to me! although, hm, not sure what happened to package-lock.json.

(Assuming this is what you're asking) When you run npm install it will update the dependencies in package-lock.json to the most recent versions that are compatible with what you have already installed. To avoid that one should npm ci instead (which, tbh, I maybe should start doing).

I understand that, it's just I'm not sure how we ended up in the position where package-lock.json has to be manually fixed again.

@essential-randomness
Copy link
Member Author

essential-randomness commented Feb 8, 2026

I don't remember a lot about this branch, but generally what happens is:

  1. PR#1 comes in with an updated package-lock.json
  2. PR#2 comes in with an updated package-lock.json
  3. PR#1 (and its package-lock.json) gets merged into main
  4. PR#2's package-lock.json now conflicts with the one on main

Every time a new package-lock.json hits main, it's likely to conflict with the ones from open PRs because the dependencies versions within have a tendency to change in incompatible ways. The solution would really be to only commit intentional changes to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants