This repository was archived by the owner on Nov 9, 2017. It is now read-only.
expose options to be able to set server_url and app_url based on request#284
Open
uwej711 wants to merge 1 commit into
Open
expose options to be able to set server_url and app_url based on request#284uwej711 wants to merge 1 commit into
uwej711 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are building a multisite facebook app so we need to be able to set the server_url and app_url based on some information stored in the database to generate the proper urls for the facebook login.
Without that change there is no way to set this as the options are only passed once in the constructor and are not accessible after.