Show channels with errors sorted by name#8910
Open
jgresty wants to merge 1 commit intoFreeTubeApp:developmentfrom
Open
Show channels with errors sorted by name#8910jgresty wants to merge 1 commit intoFreeTubeApp:developmentfrom
jgresty wants to merge 1 commit intoFreeTubeApp:developmentfrom
Conversation
When channels fail to get updated for whatever reason, they are inserted into an array of channels with errors in the order they finish processing. Since this is indeterministic it results in the channels being presented to the user in a seemingly random order. This sorts the list of channels with errors when presenting them so they are always in a consistent order.
github-actions
bot
added
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry about the drive by pull request but this was bothering me and I thought it would be less friction to just post a fix.
Pull Request Type
Related issue
n/a
Description
When channels fail to get updated for whatever reason, they are inserted into an array of channels with errors in the order they finish processing. Since this is indeterministic it results in the channels being presented to the user in a seemingly random order.
This sorts the list of channels with errors when presenting them so they are always in a consistent order.
Screenshots
Testing
getLocalChannelVideosinsrc/renderer/helpers/api/local.jsto always returnnullDesktop
Additional context