Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/dev/clang-tidy-fixes-2026-04.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@
- [PR #542](https://github.com/Framework-R-D/phlex/pull/542)
- [ ] [cppcoreguidelines-avoid-const-or-ref-data-members](https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/avoid-const-or-ref-data-members.html) (26)
- [ ] [cppcoreguidelines-avoid-non-const-global-variables](https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.html) (47)
- [ ] [cppcoreguidelines-explicit-virtual-functions](https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/explicit-virtual-functions.html) (19)
- [x] [cppcoreguidelines-explicit-virtual-functions](https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/explicit-virtual-functions.html) (19)
- [PR #545](https://github.com/Framework-R-D/phlex/pull/545)
- [ ] [cppcoreguidelines-init-variables](https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/init-variables.html) (9)
- [ ] [cppcoreguidelines-missing-std-forward](https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/missing-std-forward.html) (2)
- [ ] [cppcoreguidelines-no-malloc](https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/no-malloc.html) (1)
Expand Down
2 changes: 1 addition & 1 deletion form/persistence/persistence_reader.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace form::detail::experimental {
class PersistenceReader : public IPersistenceReader {
public:
PersistenceReader();
~PersistenceReader() = default;
~PersistenceReader() override = default;
void configureTechSettings(
form::experimental::config::tech_setting_config const& tech_config_settings) override;

Expand Down
2 changes: 1 addition & 1 deletion form/persistence/persistence_writer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace form::detail::experimental {
class PersistenceWriter : public IPersistenceWriter {
public:
PersistenceWriter();
~PersistenceWriter() = default;
~PersistenceWriter() override = default;
void configureTechSettings(
form::experimental::config::tech_setting_config const& tech_config_settings) override;

Expand Down
2 changes: 1 addition & 1 deletion form/root_storage/root_tbranch_read_container.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace form::detail::experimental {
class ROOT_TBranch_Read_ContainerImp : public Storage_Read_Container {
public:
ROOT_TBranch_Read_ContainerImp(std::string const& name);
~ROOT_TBranch_Read_ContainerImp() = default;
~ROOT_TBranch_Read_ContainerImp() override = default;

void setFile(std::shared_ptr<IStorage_File> file) override;

Expand Down
2 changes: 1 addition & 1 deletion form/root_storage/root_tbranch_write_container.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace form::detail::experimental {
class ROOT_TBranch_Write_ContainerImp : public Storage_Associative_Write_Container {
public:
ROOT_TBranch_Write_ContainerImp(std::string const& name);
~ROOT_TBranch_Write_ContainerImp() = default;
~ROOT_TBranch_Write_ContainerImp() override = default;

void setAttribute(std::string const& key, std::string const& value) override;

Expand Down
2 changes: 1 addition & 1 deletion form/root_storage/root_tfile.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace form::detail::experimental {
class ROOT_TFileImp : public Storage_File {
public:
ROOT_TFileImp(std::string const& name, char mode);
~ROOT_TFileImp();
~ROOT_TFileImp() override;

void setAttribute(std::string const& key, std::string const& value) override;

Expand Down
2 changes: 1 addition & 1 deletion form/root_storage/root_ttree_write_container.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace form::detail::experimental {
class ROOT_TTree_Write_ContainerImp : public Storage_Write_Association {
public:
ROOT_TTree_Write_ContainerImp(std::string const& name);
~ROOT_TTree_Write_ContainerImp();
~ROOT_TTree_Write_ContainerImp() override;

ROOT_TTree_Write_ContainerImp(ROOT_TTree_Write_ContainerImp const& other) = delete;
ROOT_TTree_Write_ContainerImp& operator=(ROOT_TTree_Write_ContainerImp& other) = delete;
Expand Down
2 changes: 1 addition & 1 deletion form/storage/storage_associative_write_container.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace form::detail::experimental {
class Storage_Associative_Write_Container : public Storage_Write_Container {
public:
Storage_Associative_Write_Container(std::string const& name);
~Storage_Associative_Write_Container();
~Storage_Associative_Write_Container() override;

std::string const& top_name();
std::string const& col_name();
Expand Down
2 changes: 1 addition & 1 deletion form/storage/storage_file.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace form::detail::experimental {
class Storage_File : public IStorage_File {
public:
Storage_File(std::string const& name, char mode);
~Storage_File() = default;
~Storage_File() override = default;

std::string const& name() override;
char const mode() override;
Expand Down
2 changes: 1 addition & 1 deletion form/storage/storage_read_container.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace form::detail::experimental {
class Storage_Read_Container : public IStorage_Read_Container {
public:
Storage_Read_Container(std::string const& name);
~Storage_Read_Container() = default;
~Storage_Read_Container() override = default;

std::string const& name() override;

Expand Down
2 changes: 1 addition & 1 deletion form/storage/storage_reader.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace form::detail::experimental {
class StorageReader : public IStorageReader {
public:
StorageReader() = default;
~StorageReader() = default;
~StorageReader() override = default;

using table_t = form::experimental::config::tech_setting_config::table_t;

Expand Down
2 changes: 1 addition & 1 deletion form/storage/storage_write_association.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace form::detail::experimental {
class Storage_Write_Association : public Storage_Write_Container {
public:
Storage_Write_Association(std::string const& name);
~Storage_Write_Association() = default;
~Storage_Write_Association() override = default;

void setAttribute(std::string const& key, std::string const& value) override;
};
Expand Down
2 changes: 1 addition & 1 deletion form/storage/storage_write_container.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace form::detail::experimental {
class Storage_Write_Container : public IStorage_Write_Container {
public:
Storage_Write_Container(std::string const& name);
~Storage_Write_Container() = default;
~Storage_Write_Container() override = default;

std::string const& name() override;

Expand Down
2 changes: 1 addition & 1 deletion form/storage/storage_writer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ namespace form::detail::experimental {
class StorageWriter : public IStorageWriter {
public:
StorageWriter() = default;
~StorageWriter() = default;
~StorageWriter() override = default;

using table_t = form::experimental::config::tech_setting_config::table_t;
void createContainers(
Expand Down
2 changes: 1 addition & 1 deletion phlex/core/declared_fold.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ namespace phlex::experimental {
declared_fold(algorithm_name name,
std::vector<std::string> predicates,
product_queries input_products);
virtual ~declared_fold();
~declared_fold() override;

virtual tbb::flow::sender<message>& output_port() = 0;
virtual tbb::flow::receiver<flush_message>& flush_port() = 0;
Expand Down
2 changes: 1 addition & 1 deletion phlex/core/declared_observer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ namespace phlex::experimental {
declared_observer(algorithm_name name,
std::vector<std::string> predicates,
product_queries input_products);
virtual ~declared_observer();
~declared_observer() override;
};

using declared_observer_ptr = std::unique_ptr<declared_observer>;
Expand Down
2 changes: 1 addition & 1 deletion phlex/core/declared_predicate.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ namespace phlex::experimental {
declared_predicate(algorithm_name name,
std::vector<std::string> predicates,
product_queries input_products);
virtual ~declared_predicate();
~declared_predicate() override;

virtual tbb::flow::sender<predicate_result>& sender() = 0;
};
Expand Down
2 changes: 1 addition & 1 deletion phlex/core/declared_transform.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ namespace phlex::experimental {
declared_transform(algorithm_name name,
std::vector<std::string> predicates,
product_queries input_products);
virtual ~declared_transform();
~declared_transform() override;

virtual tbb::flow::sender<message>& output_port() = 0;
virtual product_specifications const& output() const = 0;
Expand Down
2 changes: 1 addition & 1 deletion phlex/core/declared_unfold.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ namespace phlex::experimental {
std::vector<std::string> predicates,
product_queries input_products,
std::string child_layer);
virtual ~declared_unfold();
~declared_unfold() override;

virtual tbb::flow::sender<message>& output_port() = 0;
virtual tbb::flow::sender<data_cell_index_ptr>& output_index_port() = 0;
Expand Down
2 changes: 1 addition & 1 deletion phlex/core/detail/repeater_node.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ namespace phlex::experimental::detail {
bool cache_is_empty() const;
std::size_t cache_size() const;

~repeater_node();
~repeater_node() override;

private:
using base_t = tbb::flow::composite_node<repeater_node_input, message_tuple<1>>;
Expand Down
Loading