clang-tidy: resolve cppcoreguidelines-explicit-virtual-functions#545
Open
greenc-FNAL wants to merge 2 commits intomainfrom
Open
clang-tidy: resolve cppcoreguidelines-explicit-virtual-functions#545greenc-FNAL wants to merge 2 commits intomainfrom
clang-tidy: resolve cppcoreguidelines-explicit-virtual-functions#545greenc-FNAL wants to merge 2 commits intomainfrom
Conversation
- Decorated all flagged virtual destructors with `override`
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses clang-tidy’s cppcoreguidelines-explicit-virtual-functions findings by explicitly marking overriding virtual destructors with override across the Phlex core “declared_*” APIs and the FORM storage/persistence implementation classes.
Changes:
- Updated Phlex core abstract/interface-style classes (
declared_*,repeater_node) to mark virtual destructors asoverride. - Updated FORM storage/persistence concrete implementations to mark destructors as
overridewhere they implement interface/base-class virtual destructors.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| phlex/core/detail/repeater_node.hpp | Marks repeater_node destructor as overriding a virtual base destructor. |
| phlex/core/declared_unfold.hpp | Marks declared_unfold destructor as override (base: products_consumer). |
| phlex/core/declared_transform.hpp | Marks declared_transform destructor as override (base: products_consumer). |
| phlex/core/declared_predicate.hpp | Marks declared_predicate destructor as override (base: products_consumer). |
| phlex/core/declared_observer.hpp | Marks declared_observer destructor as override (base: products_consumer). |
| phlex/core/declared_fold.hpp | Marks declared_fold destructor as override (base: products_consumer). |
| form/storage/storage_writer.hpp | Marks StorageWriter destructor as override (base: IStorageWriter). |
| form/storage/storage_write_container.hpp | Marks Storage_Write_Container destructor as override (base: IStorage_Write_Container). |
| form/storage/storage_write_association.hpp | Marks Storage_Write_Association destructor as override (base: Storage_Write_Container). |
| form/storage/storage_reader.hpp | Marks StorageReader destructor as override (base: IStorageReader). |
| form/storage/storage_read_container.hpp | Marks Storage_Read_Container destructor as override (base: IStorage_Read_Container). |
| form/storage/storage_file.hpp | Marks Storage_File destructor as override (base: IStorage_File). |
| form/storage/storage_associative_write_container.hpp | Marks Storage_Associative_Write_Container destructor as override (base: Storage_Write_Container). |
| form/root_storage/root_ttree_write_container.hpp | Marks ROOT_TTree_Write_ContainerImp destructor as override. |
| form/root_storage/root_tfile.hpp | Marks ROOT_TFileImp destructor as override. |
| form/root_storage/root_tbranch_write_container.hpp | Marks ROOT_TBranch_Write_ContainerImp destructor as override. |
| form/root_storage/root_tbranch_read_container.hpp | Marks ROOT_TBranch_Read_ContainerImp destructor as override. |
| form/persistence/persistence_writer.hpp | Marks PersistenceWriter destructor as override (base: IPersistenceWriter). |
| form/persistence/persistence_reader.hpp | Marks PersistenceReader destructor as override (base: IPersistenceReader). |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #545 +/- ##
==========================================
+ Coverage 86.74% 86.76% +0.01%
==========================================
Files 142 142
Lines 5033 5033
Branches 631 631
==========================================
+ Hits 4366 4367 +1
Misses 452 452
+ Partials 215 214 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
override