feat(frontend): opt-in audio chime on successful transaction - #1387
Merged
joelpeace48-cell merged 2 commits intoSep 25, 2026
Merged
joelpeace48-cell merged 2 commits into
joelpeace48-cell merged 2 commits into
Conversation
Synthesizes a short two-note tone with the Web Audio API (no audio asset), off by default, preference persisted in localStorage, and fails silently when audio or storage is unavailable. Refs FinesseStudioLab#1234 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…oggle TransactionStatus plays the chime once per successful hash; Notification settings gains a checkbox to opt in (with a preview on enable). Closes FinesseStudioLab#1234 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@circleboyslimited Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
joelpeace48-cell
merged commit Sep 25, 2026
cd43d78
into
FinesseStudioLab:main
9 of 23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional, subtle audio chime that plays when an on-chain action turns green (the
successstate ofTransactionStatus). It is off by default, and users opt in from Notification settings.Changes
frontend/src/lib/successChime.js(new)localStorageundertrivela:success-chime.isSuccessChimeEnabledandsetSuccessChimeEnabledread and write it.AudioContext, storage is blocked or audio throws, nothing plays and the success flow is never interrupted.AudioContextis created lazily and reused, and it is resumed if the browser suspended it.frontend/src/components/TransactionStatus.jsxuseEffectcallsplaySuccessChime()whenvariant === 'success'and ahashis present. A ref makes sure it plays only once per hash, so re-renders don't repeat it.frontend/src/NotificationSettings.jsxTests
lib/successChime.test.js: it's off by default, the setting persists, it doesn't play when disabled, it plays two notes when enabled,forcepreview works, and it fails quietly without Web Audio.TransactionStatus.test.jsx: it chimes once per successful hash across re-renders, and doesn't chime for pending or error states.Tests were not run locally. CI will run them.
Closes #1234
Closes #1236
Closes #1238
Closes #1235