[SpotBugs] Style & naming (31 findings)

[clrozeboom]

Priority: LOW · 31 findings (1 high-confidence P1) · SpotBugs category 5/5

Methods that could be static, missing switch defaults, naming-convention deviations, clone() without super.clone(). Fix opportunistically when touching the file.

Note: the CN_IDIOM_NO_SUPER_CALL findings are all in *AutoLogged classes generated by the AdvantageKit annotation processor — those should be added to config/spotbugs/exclude.xml (pattern ~.*AutoLogged) rather than edited.

Patterns

• SS_SHOULD_BE_STATIC — 16 findings
• CN_IDIOM_NO_SUPER_CALL — 5 findings (all in generated *AutoLogged classes)
• SF_SWITCH_NO_DEFAULT — 5 findings
• NM_METHOD_NAMING_CONVENTION — 3 findings
• NM_VERY_CONFUSING — 1 finding
• SIC_INNER_SHOULD_BE_STATIC — 1 finding

High-confidence (P1) findings — start here

• NM_VERY_CONFUSING at org/frc5010/common/motors/function/PercentControlMotor.java:103

All findings, grouped by file

• org/frc5010/common/arch/WpiNetworkTableValuesHelper.java — 5: SF_SWITCH_NO_DEFAULT×5 (lines 351, 385, 409, 450, 490)
• org/frc5010/common/commands/DriveToPoseSupplier.java — 4: SS_SHOULD_BE_STATIC×4 (lines 66, 67, 74, 85)
• org/frc5010/common/motors/function/VerticalPositionControlMotor.java — 3: SS_SHOULD_BE_STATIC×3 (lines 52, 53, 54)
• org/frc5010/common/auto/AutoPath.java — 2: NM_METHOD_NAMING_CONVENTION×2 (lines 46, 61)
• org/frc5010/common/commands/calibration/WheelRadiusCharacterization.java — 2: SS_SHOULD_BE_STATIC×2 (lines 33, 34)
• org/frc5010/common/motors/function/PercentControlMotor.java — 1: NM_VERY_CONFUSING (line 103)
• frc/robot/example/subsystems/ExampleIOInputsAutoLogged.java — 1: CN_IDIOM_NO_SUPER_CALL (line 60, generated)
• org/frc5010/common/arch/GenericCommandSequence.java — 1: SS_SHOULD_BE_STATIC (line 24)
• org/frc5010/common/arch/StateMachine.java — 1: SIC_INNER_SHOULD_BE_STATIC (line 455)
• org/frc5010/common/auto/AutoSequence.java — 1: NM_METHOD_NAMING_CONVENTION (line 116)
• org/frc5010/common/drive/pose/DrivePoseEstimatorInputsAutoLogged.java — 1: CN_IDIOM_NO_SUPER_CALL (line 72, generated)
• org/frc5010/common/drive/pose/VisionIOInputsAutoLogged.java — 1: CN_IDIOM_NO_SUPER_CALL (line 44, generated)
• org/frc5010/common/drive/swerve/akit/GyroIOInputsAutoLogged.java — 1: CN_IDIOM_NO_SUPER_CALL (line 28, generated)
• org/frc5010/common/drive/swerve/akit/ModuleIOInputsAutoLogged.java — 1: CN_IDIOM_NO_SUPER_CALL (line 50, generated)
• org/frc5010/common/motors/function/AngularControlMotor.java — 1: SS_SHOULD_BE_STATIC (line 49)
• org/frc5010/common/motors/hardware/GenericRevBrushlessMotor.java — 1: SS_SHOULD_BE_STATIC (line 66)
• org/frc5010/common/motors/hardware/GenericTalonFXMotor.java — 1: SS_SHOULD_BE_STATIC (line 44)
• org/frc5010/common/motors/hardware/GenericTalonFXSMotor.java — 1: SS_SHOULD_BE_STATIC (line 45)
• org/frc5010/common/sensors/absolute_encoder/GenericAbsoluteEncoder.java — 1: SS_SHOULD_BE_STATIC (line 15)
• org/frc5010/common/subsystems/SegmentedLedSystem.java — 1: SS_SHOULD_BE_STATIC (line 31)

Full detail

Complete file:line table: docs/SPOTBUGS_TRIAGE.md (section 5).
Regenerate the report with ./gradlew spotbugsMain → build/reports/spotbugs/main.html.