[SpotBugs] Dead / unused code (65 findings)

[clrozeboom]

Priority: MED · 65 findings (2 high-confidence P1) · SpotBugs category 3/5

Fields that are never read, never written, or entirely unused, plus dead local stores and an uncalled private method. Continuation of the Phase 0 dead-code cleanup. Mostly safe deletions, but beware fields read reflectively (Jackson POJOs) or by dashboards.

Patterns

• URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD — 21 findings
• UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD — 12 findings
• URF_UNREAD_FIELD — 11 findings
• UUF_UNUSED_FIELD — 7 findings
• UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD — 6 findings
• DLS_DEAD_LOCAL_STORE — 4 findings
• UWF_UNWRITTEN_FIELD — 3 findings
• UPM_UNCALLED_PRIVATE_METHOD — 1 finding

High-confidence (P1) findings — start here

• DLS_DEAD_LOCAL_STORE at org/frc5010/common/commands/DriveToTrajectory.java:62
• DLS_DEAD_LOCAL_STORE at org/frc5010/common/commands/SmartSwerveDrive.java:102

All findings, grouped by file

• org/frc5010/common/commands/DriveToTrajectory.java — 10: URF_UNREAD_FIELD×4, DLS_DEAD_LOCAL_STORE×2, UUF_UNUSED_FIELD×2, UWF_UNWRITTEN_FIELD×2 (lines 37, 57, 62, 66, 84, 85, 121)
• org/frc5010/common/drive/SwerveDriveConfig.java — 7: URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD×7 (lines 190, 195, 200, 205, 210, 215, 220)
• org/frc5010/common/commands/DriveToPoseSupplier.java — 5: URF_UNREAD_FIELD×3, UUF_UNUSED_FIELD×1, DLS_DEAD_LOCAL_STORE×1 (lines 42, 75, 77, 230)
• org/frc5010/common/drive/swerve/AkitSwerveConfig.java — 4: UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD×4 (lines 141, 142, 194)
• org/frc5010/common/motors/hardware/GenericTalonFXSMotor.java — 4: UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD×2, UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD×1, URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD×1 (lines 238, 263, 509)
• frc/robot/example/ExampleRobot.java — 3: URF_UNREAD_FIELD×2, UUF_UNUSED_FIELD×1 (lines 21, 28)
• org/frc5010/common/sensors/camera/QuestNavInterface.java — 3: UUF_UNUSED_FIELD×2, UWF_UNWRITTEN_FIELD×1 (line 276)
• frc/robot/baby_swerve/BabySwerve.java — 2: UUF_UNUSED_FIELD×1, URF_UNREAD_FIELD×1 (line 19)
• frc/robot/example/subsystems/ExampleIOSim.java — 2: UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD×2
• org/frc5010/common/config/json/devices/MotorSetupJson.java — 2: UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD×2 (line 53)
• org/frc5010/common/config/json/devices/SubsystemJson.java — 2: UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD×2 (lines 38, 40)
• org/frc5010/common/motors/hardware/GenericTalonFXMotor.java — 2: UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD×1, URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD×1 (line 508)
• org/frc5010/common/commands/SmartSwerveDrive.java — 1: DLS_DEAD_LOCAL_STORE (line 102)
• frc/robot/example/subsystems/ExampleIOReal.java — 1: URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD (line 36)
• org/frc5010/common/commands/calibration/WheelRadiusCharacterization.java — 1: UPM_UNCALLED_PRIVATE_METHOD (line 83)
• org/frc5010/common/config/json/GamePieceJson.java — 1: UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD
• org/frc5010/common/config/json/GamePiecesJson.java — 1: UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD (line 19)
• org/frc5010/common/config/json/devices/YamsConfigCommon.java — 1: UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD (line 142)
• org/frc5010/common/drive/pose/GenericPose.java — 1: URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD (line 28)
• org/frc5010/common/drive/swerve/GenericSwerveModuleInfo.java — 1: URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD (line 28)
• org/frc5010/common/motors/function/GenericControlledMotor.java — 1: URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD (line 104)
• org/frc5010/common/motors/function/PercentControlMotor.java — 1: URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD (line 65)
• org/frc5010/common/sensors/absolute_encoder/GenericAbsoluteEncoder.java — 1: URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD (line 17)
• org/frc5010/common/sensors/camera/GenericCamera.java — 1: URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD (line 31)
• org/frc5010/common/sensors/encoder/SimulatedEncoder.java — 1: URF_UNREAD_FIELD (line 15)
• …plus 6 more files (6 findings) — see the full table in the triage doc.

Full detail

Complete file:line table: docs/SPOTBUGS_TRIAGE.md (section 3).
Regenerate the report with ./gradlew spotbugsMain → build/reports/spotbugs/main.html.