[feature]: Display selection count message across data tables #344
Open
deeonwuli wants to merge 6 commits into
Open
[feature]: Display selection count message across data tables #344deeonwuli wants to merge 6 commits into
deeonwuli wants to merge 6 commits into
Conversation
…boardTable, UserGroupTable, and UserRoleTable
Member
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
eperedo
reviewed
Apr 27, 2026
eperedo
left a comment
eperedo
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but I think it would be useful to have this on d2-ui-components so we can have this change available for all of our apps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
The d2-ui-components selection banner is only triggered when items are selected on other pages, so a user could select rows down the current page without any visual cue and apply an unintended bulk action.
useTableWithSelectionCounthook to track table selectionuseObjectsTablecalls with the new hook inUserListTable📹 Screenshots/Screen capture
Screen.Recording.2026-04-20.at.10.25.41.mov
🔥 Testing
#869cqxtfn