Fixed VirtualizedList "Invalid cells around viewport" crash in money request reports#91108
Open
shubham1206agra wants to merge 1 commit into
Open
Fixed VirtualizedList "Invalid cells around viewport" crash in money request reports#91108shubham1206agra wants to merge 1 commit into
shubham1206agra wants to merge 1 commit into
Conversation
Contributor
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
@situchan can you lease prioritize this review? |
Contributor
|
yes but do we have consistent repro step? |
Contributor
|
@shubham1206agra Do you know? do you know maybe from full story what steps the users are taking to get this crash? if you then send me their email in DM I can check on adhoc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
RCA: During transient mount frames in the iOS hybrid app (Wide RHP overlay animation),
useWindowDimensions()momentarily returnsheight: 0, making the height-basedinitialNumToRendercalculation produce a negative number that violatesVirtualizedList's _createRenderMaskinvariant.Fixed Issues
$ #90957
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-05-19.at.11.23.18.PM.mov
Screen.Recording.2026-05-19.at.11.31.54.PM.mov