Added support for loading referenced .dlls to the app domain in .NET Core#849
Added support for loading referenced .dlls to the app domain in .NET Core#849Sergey-Vlasov wants to merge 4 commits into
Conversation
|
How does the LoadFrom(path) interact with the AssemblyLoadContext here? It sounded like the EnterContextualReflection call was better - that ensures the chain of loaded assemblies resolve inside the ALC. Otherwise, they might load into the default ALX, which we don't want. It might be helpful to check the ALCs for the assemblies afterwards to confirm. |
|
Yes, the implemented AppDomain.CurrentDomain.AssemblyResolve solution loads into the default global ALC. EnterContextualReflection is a solution, if the add-in developer can add the code to invoke it. Actually, we can use both. The implemented AssemblyResolve makes sure the add-in doesn’t crash by default, and if the add-in requires private ALC then adding a call to EnterContextualReflection per guidance will make it so. |
No description provided.