fix!: make tesla patch not be a foreach of players#796
fix!: make tesla patch not be a foreach of players#796Unbistrackted wants to merge 5 commits intoExMod-Team:devfrom
Conversation
|
btw my first actual Transpiler pr, hope this is not that ass cause I was just looking into how other patches did it |
This just overcomplicated it it's a lot better to have only a single event to trigger tesla ?? |
|
I'll admit that this even definitely looks like it needs some work on it. Considering the plans for Exiled 10, we might just want to replace our events with just the LabAPI ones like what I said for #791 |
|
I talked with yamato abt it, but just in case I made it simpler per his request |
|
talk with him in DM and conclude than yeah this can't be done better without Reworking SL and using Sphere Collider to trigger player that would enter it |
Description
Describe the changes
Make tesla patch not be a foreach of players by doing a proper patch
What is the current behavior? (You can also link to an open issue here)
Foreach loop of players
What is the new behavior? (if this is a feature change)
Proper patch
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Remove
TriggeringTeslaEventArgs::IsInIdleRange,TriggeringTeslaEventArgs::IsInHurtingRangeOther information:

Also this event was getting triggered every frame even if the conditions did not match
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other