Skip to content

fix!: make tesla patch not be a foreach of players#796

Closed
Unbistrackted wants to merge 5 commits intoExMod-Team:devfrom
Unbistrackted:player-tesla-event
Closed

fix!: make tesla patch not be a foreach of players#796
Unbistrackted wants to merge 5 commits intoExMod-Team:devfrom
Unbistrackted:player-tesla-event

Conversation

@Unbistrackted
Copy link
Copy Markdown

@Unbistrackted Unbistrackted commented Mar 31, 2026

Description

Describe the changes
Make tesla patch not be a foreach of players by doing a proper patch

What is the current behavior? (You can also link to an open issue here)
Foreach loop of players

What is the new behavior? (if this is a feature change)
Proper patch

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Remove TriggeringTeslaEventArgs::IsInIdleRange, TriggeringTeslaEventArgs::IsInHurtingRange

Other information:
{989FE7F8-948A-4A98-8ED8-594A4D34A3EE}
Also this event was getting triggered every frame even if the conditions did not match


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Unbistrackted
Copy link
Copy Markdown
Author

Unbistrackted commented Mar 31, 2026

btw my first actual Transpiler pr, hope this is not that ass cause I was just looking into how other patches did it

@louis1706
Copy link
Copy Markdown

btw my first actual Transpiler pr, hope this is not that ass cause I was just looking into how other patches did it

This just overcomplicated it it's a lot better to have only a single event to trigger tesla ??

@louis1706 louis1706 added the Do not merge Don't merge this PR label Mar 31, 2026
@Someone-193
Copy link
Copy Markdown

I'll admit that this even definitely looks like it needs some work on it. Considering the plans for Exiled 10, we might just want to replace our events with just the LabAPI ones like what I said for #791

@Unbistrackted
Copy link
Copy Markdown
Author

I talked with yamato abt it, but just in case I made it simpler per his request

@louis1706
Copy link
Copy Markdown

talk with him in DM and conclude than yeah this can't be done better without Reworking SL and using Sphere Collider to trigger player that would enter it

@louis1706 louis1706 closed this Apr 1, 2026
@Unbistrackted Unbistrackted deleted the player-tesla-event branch April 3, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do not merge Don't merge this PR Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants