Draft
Conversation
- I use the folder name without the `worldeditcui-` prefix, as per the latest architectury template. It also helps with the migration and could be changed at the end.
- move all versions values to the `[versions]` section - reorder all deps into commented section between mod loaders, CUI deps and dev deps - remove `child fabric-api-*` deps, they are included in the main `fabric-api` deps.
- added architectury - added fabricLoader - kept only the base `fabric-api`
…le to the same thing as the fabric metadata
- based on architectury template
- fabric-specific are moved into the fabric build script - everything is moved inside the `subprojects` - java version is removed from the properties and moved inside the build script - added architectury plugin and its config - removed config related to vineflower - TODO: Reintegrate the spotless plugin
- TODO: Reintegrate the releasing tasks - TODO: Reintegrate the `modLocalRuntime` dependency for development if needed. Left out until validation if Fabric specific or both. - TODO: Reintegrate the task `generateStandaloneRun`. Left out until validation if Fabric specific or both. - for fabric, using the main root fabric-api dependency instead of the multiple child one. - removed the mixin configuration as no mixin are used. - only added dependencies called in the code, such as `viafabricplus` being left out, keeping only `viaversion`. this needs to be validated. - removed the loom client config; it did not seems to affect the build. this needs to be validated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #151.
I keep as draft since some configs and tasks were removed (The Kotlin DSL gave me multiple headaches when adding the architectury plugin and a second subproject). Don't worry, they will be re-added before removing draft status.
However, it does compile and works in both Fabric and NeoForge doing a very simple test of loading a world and testing if the grid is showing as expected.
I'll write distinct comments for specific validation/question required to understand if it is fabric-specific, needed for both fabric and neoforge, or even legacy stuff (I mean, it does work as it is 😅).