Fix issue with benches - #1508
Merged
Merged
Conversation
Co-authored-by: Alex Dewar <alexdewar@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the select_best_assets benchmark to match the current simulation API after a function change, so the benches compile and run again.
Changes:
- Replace the removed
collect_investment_limits_for_candidatesusage withcollect_agent_addition_limits. - Update benchmark setup and the
select_best_assetscall to pass agent addition limits.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1508 +/- ##
=======================================
Coverage 90.30% 90.30%
=======================================
Files 60 60
Lines 8658 8658
Branches 8658 8658
=======================================
Hits 7819 7819
Misses 525 525
Partials 314 314 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A function had changed, so benches were failing.
Fixes # (issue)
Type of change
Key checklist
$ cargo test$ cargo docpresent in the previous release
Further checks