Change palace lengths into a 4 choice dropdown#376
Merged
Ellendar merged 1 commit intoEllendar:5.1from Feb 16, 2026
Merged
Conversation
Ellendar
reviewed
Feb 12, 2026
Owner
Ellendar
left a comment
Ellendar
left a comment
There was a problem hiding this comment.
This behavior (that rooms with variants appear more often because they have more variants) is a desired behavior. It keeps the distribution of rooms close to the distribution you'd see in vanilla. I really do not want to change that.
initsu
force-pushed
the
palace-lengths
branch
from
10fcdf0 to
b9a8688
Compare
- This also affects random item per palace count (because the lengths vary more with the introduction of Medium). The 1-3 max is now determined by the rolled length instead of palace number.
initsu
force-pushed
the
palace-lengths
branch
from
b9a8688 to
3a77e8c
Compare
Collaborator
Author
|
I moved the commit then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the final commit is new here (and these all change the same files).
Change palace lengths into a 4 choice enum
The 1-3 max is now determined by the rolled length instead of palace number.