Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ lib/
*.tgz
node_modules/
npm-debug.log
package-lock.json
yarn-error.log

# Editors:
Expand Down
2 changes: 2 additions & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
legacy-peer-deps=true
ignore-scripts=true
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npmrc ignore-scripts breaks pretest and prepare lifecycle hooks

High Severity

Setting ignore-scripts=true in .npmrc has broader scope than the old .yarnrc --ignore-scripts true. Yarn's setting only affected yarn install, but npm's setting is global — it causes npm test to skip pretest (which runs build:test) and npm publish to skip prepare (which runs build). Since the test script expects build/tests.js to exist (built by pretest), npm test will fail. The prepare hook not running also means npm publish may ship without a fresh build.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e77c17d. Configure here.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged as a real behavior change: npm's global ignore-scripts=true (ported faithfully from .yarnrc --ignore-scripts true) also suppresses this repo's own pretest (→ build:test) and prepare (→ build), so npm test and publish do not build first the way the prior yarn setup allowed. It is left as an intentional carry-over for the migration rather than re-scoped here.

1 change: 0 additions & 1 deletion .yarnrc

This file was deleted.

Loading
Loading