Convert from yarn to npm#13
Open
peachbits wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f4ec5ec. Configure here.
| @@ -0,0 +1,2 @@ | |||
| legacy-peer-deps=true | |||
| ignore-scripts=true | |||
There was a problem hiding this comment.
Install scripts skip lib build
High Severity
Setting ignore-scripts=true stops npm install / npm ci from running the root prepare script, which is what compiles TypeScript into lib/. That output is listed in .gitignore and is the package main entry, so a normal install leaves the library without a loadable build until someone runs prepare by hand.
Reviewed by Cursor Bugbot for commit f4ec5ec. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Low Risk
Tooling-only change (lockfile and install flags); no application or native wallet logic is modified in the diff.
Overview
This PR switches the repo from Yarn to npm by checking in npm’s install metadata and local install policy.
A new
package-lock.json(lockfile v3) pins the tree forreact-native-zano@0.2.8, including the existing runtime depcleanersand the current ESLint/TypeScript/Husky dev toolchain.A new
.npmrcsetslegacy-peer-deps=true(looser peer resolution during install) andignore-scripts=true(skips lifecycle scripts onnpm install).Reviewed by Cursor Bugbot for commit f4ec5ec. Bugbot is set up for automated code reviews on this repo. Configure here.