Convert yarn → npm + Socket security upgrades + @edge.app fork aliases#449
Open
peachbits wants to merge 3 commits into
Open
Convert yarn → npm + Socket security upgrades + @edge.app fork aliases#449peachbits wants to merge 3 commits into
peachbits wants to merge 3 commits into
Conversation
added 3 commits
May 26, 2026 14:10
Two upstream-unfixable alerts remain: - request@2.88.2 (moderate; direct dep, package deprecated, no fix) - elliptic@6.6.1 (low; latest published) Set SOCKET_CLI_ACCEPT_RISKS=1 for plain `npm install` to clear them.
Replaces direct `ecpair` git URL with an npm alias to `@edge.app/ecpair@^2.1.0-edge.1`. Adds `overrides` so the transitive `bs58grscheck@^2` (via `wifgrs<2.0.7`) and `groestl-hash-js` resolve through `@edge.app/bs58grscheck@^2.1.2-edge.1` and `@edge.app/groestl-hash-js@^1.0.0-edge.1`. Result: zero true git deps in the install graph. Plain `npm install` no longer triggers the git-dep-prep code path that conflicts with `min-release-age` in user-level npmrc (npm/cli#9005). The direct `bs58grscheck@^3.0.1` dep is untouched (registry, no git URL); the `bs58grscheck@^2` override is scoped so it only intercepts the v2 transitive path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three-commit branch:
synplockfile, drop.yarnrc, write.npmrc(legacy-peer-deps=true+ignore-scripts=true), rewrite scripts and docs.socket fix --no-major-updates+ iterativeoverridesfor transitive CVEs.ecpairdirect dep +bs58grscheck@^2andgroestl-hash-jstransitive overrides now resolve through the npm registry instead of GitHub git URLs. Avoids the npm git-dep-prep code path that conflicts withmin-release-agein user~/.npmrc(npm/cli#9005).The direct
bs58grscheck@^3.0.1dep is untouched (it's a clean registry resolution); only the v2 transitive path throughwifgrs<2.0.7is redirected to the @edge.app fork.Test plan
sfw npm installsucceeds with a fresh~/.npmrccontainingmin-release-age=7(after 7 days have passed since @edge.app/* publishes, or vianpm ci)npm run preparecompletesNote
Low Risk
Tooling and documentation only; no runtime currency or wallet logic changes in the shown diff.
Overview
This PR finishes the switch from Yarn to npm for day-to-day and CI workflows.
.yarnrcis removed,.npmrcis added withlegacy-peer-deps=trueandignore-scripts=true(matching the old Yarn ignore-scripts behavior), and.gitignoreno longer excludespackage-lock.jsonso the npm lockfile is tracked. Travis runsnpm run verifyinstead ofyarn verify.README and currency-integration docs now tell contributors to use
npm run startfor the Webpack dev server instead ofyarn start.Reviewed by Cursor Bugbot for commit 8b52161. Bugbot is set up for automated code reviews on this repo. Configure here.