Renaming error in case of file duplication#136
Open
indexlang wants to merge 1 commit intoEasyAbp:masterfrom
Open
Renaming error in case of file duplication#136indexlang wants to merge 1 commit intoEasyAbp:masterfrom
indexlang wants to merge 1 commit intoEasyAbp:masterfrom
Conversation
gdlcf88
reviewed
Aug 8, 2024
| fileNames | ||
| .Select(x => | ||
| x.Substring(part1.Length, x.LastIndexOf(part2, StringComparison.Ordinal) - part1.Length)) | ||
| x.LastIndexOf(part2, StringComparison.Ordinal) > 0 ? x.Substring(part1.Length, x.LastIndexOf(part2, StringComparison.Ordinal) - part1.Length) : "") |
Member
There was a problem hiding this comment.
How about
.Where(x => x.EndsWith(part2, StringComparison.Ordinal))
Member
There was a problem hiding this comment.
No need to select and parse unused items ("").
Author
There was a problem hiding this comment.
If client upload a file end with ")",also need parse str,so I think both are fine,you decide.
Member
There was a problem hiding this comment.
I prefer to keep the .Select() line unchanged and add
.Where(x => x.EndsWith(part2, StringComparison.Ordinal))for minimal impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#135 (comment)