-
Notifications
You must be signed in to change notification settings - Fork 2
Harmonize rimport and relink #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For consistency with relink.
Changes behavior to hide inputdata_root help text.
To match relink behavior.
jedwards4b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
|
Need to fix the testing before it's ready to merge. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 97.76% 99.12% +1.36%
==========================================
Files 21 27 +6
Lines 2010 2746 +736
==========================================
+ Hits 1965 2722 +757
+ Misses 45 24 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Work to prepare for addressing #14. Only one behavior should be changed:
rimport --helpno longer mentions-inputdata. This makes it consistent withrelink.py.Some new behaviors:
rimportcan now accept both--fileand--filelist, as well as (likerelink.py) positional arguments.relink.pynow prints filename and indents other messages likerimportdoes.inputdataoption flags between scripts.relink.pynow accepts-helpflag likerimportalready does.rimportnow uses Python'sloggingmodule and accepts--quiet/--verboseoptions likerelink.pydoes. (Currently--verbosewill print no additional messages, but the capability is there and tested.)