-
Notifications
You must be signed in to change notification settings - Fork 2
rimport: Add --check functionality #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Makes it easier to understand output when processing lists of files.
stage_data() has special handling for symlinks, but they were getting resolved (i.e., replaced with their targets) during resolve_paths(), so stage_data() only ever saw their targets. resolve_paths() has been renamed to normalize_paths() and no longer resolves symlinks. Tests have been added to ensure this behavior is preserved.
Resolves ESMCI#2.
jedwards4b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
========================================
Coverage 97.76% 97.76%
========================================
Files 21 22 +1
Lines 2010 2195 +185
========================================
+ Hits 1965 2146 +181
- Misses 45 49 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
New
rimportoption--checkchecks whether file has been published but does not attempt copy.Resolves #2.
Other changes:
relink.)rimporting a list of files.